[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 20 Dec 2023 12:27:26 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGkhK85WRpALsvbvriQYc0W9/0wp6up+v/Jy1+/wY68=; b=dQnyWijAkIaP9957NGuqsJ3uwlGAqqLoY6gWZ6XHVrn692Jta4Hz39i9XE4VTKQxS9S/GeJiBoFOoW49q2MELeWgv5VT4ifLRoG61V8mYa4Ce5LfjJkoJd3qzIikEFsWp5wiPWKZ9gtCUkVJyajJuib4ytvZlKJM1ZBf/sjNgB2h6SUu0+VdB+0+VwqdzRRMQT1fYLVyX7Z1yDIMqPG+lsvjceyJTrNnkyvdcFLmSuQ1zQkso2SNFbcV0UITj96f3GqjvkoLDKM9wGX0b+Umwdhe8eaJZGuVCrX6XhwJBy+nsvl4BZrW24cSK6iPss222hOgAUguyFTIvf7Y1Z4mYg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nGkhK85WRpALsvbvriQYc0W9/0wp6up+v/Jy1+/wY68=; b=Vs1T5hshrbyx/26Fn4SaB5ODjF4hG5WhAbU1yv07RArvRAjAChX7gFbL3sTRR+B5EHHSGLoLlXjMOPS28y1l5YsxLAqqEVUTPz6Yf1X+3o/tSJtyhTgt/+RSeWCRDVqu4//AhI5t9Ta1irXWlROwG1qt+kDd55jo0wyRNaQ9mqGJP+lCcxegcUtbAJGs5rUGC30SSb6WJcenjtONvcXvfU5/ll+9N7OIK7/xj1pUS0K7pZkIebGP9wfW9erF8omNKS+V32Hbb0modz7noodwpoyVECMvTRTR+58SM4AUU1vGPV01ZhsYm1ZAyHLAVYddU7ma4YKdg13RLWKC2v31sw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OAiJ7mVfASqbzvXolgHs6G7gmgWuEEnStMVprNXwuvjHrGyUEKdAvSUJOWLvBzRzyXMgKKaowwEtzJMbP1yLT4Nvv8UrcT/6v2eZ4GEQtGOlN/Ob7s7SFDy/Lf1IPnRJjOIYIlYqtrzKmQNTcnDFkh5H8NxMrB+xgv7fei3wkQjlnlmOzT9CryniRkUAtgirUZ/ZH+qwbOrYjEJ+cGtIVfoThb2hPcouXUXlBlUHYDLeGXIMgvPS1h4Sr33nanlSsDlQqJ18cJRHjcuOsqc6j6VXMJm6IiGpR6UhE2uBWLlOQKZ37c8g6IHLDrRJOEz62MtOn1OKq3BX+G7urjCaRw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1b3nHDClnjL7JUXou+hl4kQ/OTBhEeI6Fr/9aMh1KO9EIY7LbgPFoLWxNBsqD5Xzt0nGbRZTVue14TVmXLzgob0m9RnLdGesAIKLRwn3A9k/R2sb6GpMu1LN0ULb0I18kVz1/CKZeeLXc4cWBjU0RYjed8JHmsa2Z8MJ9eRO6ICfZ3L98vOetHBqVdiXsXZq0R9sgJgG50aFOBWRb5wkXt/CPVHHJdFeDu1vGHeLteaCOesygFl3Rxp1oPGGrLVgy1QW5SonOLGL4mCqtPtjDHbhh9c3k3OGTUe848WXkJplzUTpFSDdNKCxnaUAXuuV8NWgUtfETxzq3gKloZBSQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "stefano.stabellini@xxxxxxx" <stefano.stabellini@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 20 Dec 2023 12:27:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaMfEa7o9h58xZgUaSJIw5Lcks+LCx6kEAgAAD4ACAACpXAIAAA2CA
- Thread-topic: [PATCH v2 0/3] xen/arm: Add emulation of Debug Data Transfer Registers
>
> I wanted to keep Michal's change for the arm64 as it is. And introduce
> Kconfig and command line in separate patches.
>
> But I agree, it does not look clean.
>
>
> I am fine to follow your suggestion ie (Option 1)
>
> Patch 1 ---> arm64 changes + Kconfig + cmd_line (authored by Michal)
>
> Patch 2 ---> arm32 changes (which will use the Kconfig and cmd_line
> introduced before)
>
>
> Alternatively, I am thinking like this (Option 2)
>
> Patch 1 --> arm64 changes (authored by Michal)
>
> Patch 2 --> arm32 changes
>
> Patch 3 ---> Kconfig + cmd_line (which will touch patch 1 and 2).
>
> Let me know what you (+ Stefano, Julien, Bertrand) think about the split.
>
> I don't have a strong preference on how the split should be done.
The maintainers will decide, but I feel that with option 2, there will be,
in the tree, a state where the design decision won’t be fulfilled, so
with patch 1 and 2 we will have partial emulation unconditionally.
Instead with option 1 we will have always a proper state, which will
be arm64 conditional partial emulation with patch 1 and arm32 conditional
partial emulation with patch 2.
Maybe maintainers will decide if that matters or not.
Cheers,
Luca
|
