[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm/gicv3: Fix ICH_VTR_EL2.ListRegs mask





On 10/09/2024 09:49, Bertrand Marquis wrote:
Hi Michal,

On 3 Sep 2024, at 14:21, Michal Orzel <michal.orzel@xxxxxxx> wrote:

According to GIC spec IHI 0069H.b (12.4.9), the ListRegs field of
ICH_VTR_EL2 can have value between 0b00000..0b01111, as there can
be maximum 16 LRs (field value + 1). Fix the mask used to extract this
value which wrongly assumes there can be 64 (case for GICv2).

Fixes: bc183a0235e0 ("xen/arm: Add support for GIC v3")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>

Nice finding.

+1. I guess we haven't seen any issue so far because the bits afterwards are RES0.


Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Committed.

Cheers,

--
Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.