Re: Cryptokit.Random unsuitable in cooperative multithreaded systems

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

On 25 Apr 2013, at 15:27, Vincent Bernardoff <vb@xxxxxxxxxxxxxx> wrote:

> On 25/04/2013 14:51, Anil Madhavapeddy wrote:
>> So in this situation, I would improve the bug report with a patch against 
>> 1.7 and follow up to Xavier with the rebased patch to the latest release.  
>> And a belated question: why do you need SHA-512, out of interest?
> 
> I needed it when I did my bitcoin arbitrage bot experiment. One bitcoin 
> exchange (mtgox) uses it in its RPC protocol, to identify a user.

Nice!

> For cryptokit, the delicate thing is that the sha512 code is not my code. I 
> replaced Xavier's code for all sha functions by Vincent's one, as it is more 
> efficient. I am not sure if he is interested in that anyway. I could start 
> with doing a patch with sha512 code, to see his reaction.

Yes, each patchset should have a small set of changes, so that they can be 
selected or dropped as needed.

-anil