[Xen-changelog] [xen-unstable] libxl: remus: mark TODOs more clearly

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
# Date 1343984053 -3600
# Node ID 646a1deabd189fca948385fc0c0c1d28a7c63664
# Parent  f1e7c1142fe515171df742b3748828b758d5f88b
libxl: remus: mark TODOs more clearly

Change the TODOs in the remus code to "REMUS TODO" which will make
them easier to grep for later.  AIUI all of these are essential for
use of remus in production.

Also add a new TODO and a new assert, to check rc on entry to
remus_checkpoint_dm_saved.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---


diff -r f1e7c1142fe5 -r 646a1deabd18 tools/libxl/libxl_dom.c
--- a/tools/libxl/libxl_dom.c   Fri Aug 03 09:54:12 2012 +0100
+++ b/tools/libxl/libxl_dom.c   Fri Aug 03 09:54:13 2012 +0100
@@ -1110,7 +1110,7 @@ int libxl__toolstack_save(uint32_t domid
 
 static int libxl__remus_domain_suspend_callback(void *data)
 {
-    /* TODO: Issue disk and network checkpoint reqs. */
+    /* REMUS TODO: Issue disk and network checkpoint reqs. */
     return libxl__domain_suspend_common_callback(data);
 }
 
@@ -1124,7 +1124,7 @@ static int libxl__remus_domain_resume_ca
     if (libxl_domain_resume(CTX, dss->domid, /* Fast Suspend */1))
         return 0;
 
-    /* TODO: Deal with disk. Start a new network output buffer */
+    /* REMUS TODO: Deal with disk. Start a new network output buffer */
     return 1;
 }
 
@@ -1151,8 +1151,9 @@ static void libxl__remus_domain_checkpoi
 static void remus_checkpoint_dm_saved(libxl__egc *egc,
                                       libxl__domain_suspend_state *dss, int rc)
 {
-    /* TODO: Wait for disk and memory ack, release network buffer */
-    /* TODO: make this asynchronous */
+    /* REMUS TODO: Wait for disk and memory ack, release network buffer */
+    /* REMUS TODO: make this asynchronous */
+    assert(!rc); /* REMUS TODO handle this error properly */
     usleep(dss->interval * 1000);
     libxl__xc_domain_saverestore_async_callback_done(egc, &dss->shs, 1);
 }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog