[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] [2/4] put xen console message into syslog but?xm dmesg is not affected

On Tue, Jul 11, 2006 at 04:13:01PM +0100, Keir Fraser wrote:
> On 11 Jul 2006, at 13:30, Horms wrote:
> >>Let's not add extra code styles to the tree: either format your code 
> >>in
> >>Xen style (4-space soft tabs; braces on their own lines) or in Linux
> >>style (hard tabs; K&R style).
> >
> >Two is already one too many IMHO :-)
> As long as each discrete 'tool' or library is self-consistent in which 
> it picks I don't really see a problem. In fact I wouldn't be too 
> bothered about having more than two styles to choose from -- but 
> two-space soft tabs are not an option as far as I'm concerned, which is 
> the main reason I commented. There are more important issues than petty 
> battles over coding standards.

Sorry, I was niggling a bit. I don't mind too much either, as long
as its clear which directories (or files) use which standard. Though
it is a bit of a mind-warp when you have files from xen/ and some kernel
files open at the same time. I had to get quite good at teaching my
editor what to do for me.

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.