Re: [Xen-devel] [PATCH v4 07/10] hvm/hpet: Init comparator64 like comparator.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.05.14 at 22:18, <dslutz@xxxxxxxxxxx> wrote:
> The software-developers-hpet-spec-1-0a.pdf says that the comparator
> starts as all 1's.  Also make the hidden register comparator64 the same.
> 
> Since only the hidden register comparator64 is used by hpet_save, it
> needs to start out with the right value.
> 
> A disabled hpet (like when a guest is starting), should start with
> the value the spec says.  Both the guest (via reading the
> comparator) and an administrator using xen-hvmctx, will see all 0's
> not all 1's.
> 
> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
> v4:
>   Added paragraph starting "A disabled hpet" to commit message.
> 
>  xen/arch/x86/hvm/hpet.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/x86/hvm/hpet.c b/xen/arch/x86/hvm/hpet.c
> index b611304..741fb7a 100644
> --- a/xen/arch/x86/hvm/hpet.c
> +++ b/xen/arch/x86/hvm/hpet.c
> @@ -636,6 +636,7 @@ void hpet_init(struct vcpu *v)
>          h->hpet.timers[i].config =
>              HPET_TN_INT_ROUTE_CAP | HPET_TN_64BIT_CAP | 
> HPET_TN_PERIODIC_CAP;
>          h->hpet.timers[i].cmp = ~0ULL;
> +        h->hpet.comparator64[i] = ~0ULL;
>          h->pt[i].source = PTSRC_isa;
>      }
>  }
> -- 
> 1.8.4




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel