Re: [Xen-devel] [PATCH V5 04/32] libxl: libxl_uuid_copy now taks a ctx argument

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 16, 2014 at 12:23:57PM +0100, Ian Campbell wrote:
> On Fri, 2014-05-16 at 12:21 +0100, Wei Liu wrote:
> 
> > libxl_internal.h:56:3: error: #error libxl.h should be included via 
> > libxl_internal.h, not separately
> > libxl_internal.h:59:0: error: "LIBXL_EXTERNAL_CALLERS_ONLY" redefined 
> > [-Werror]
> 
> I forgot about this. I think with this change you don't need the libxl.h
> include in libxl_uuid.h. It is included either via libxl.h or
> libxl_internal.h. 
> 

I don't see inclusion of libxl_internal.h in libxl_uuid.h.

Removing the inclusion of libxl.h in libxl_uuid.h results in this:

gcc  -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs
-D__XEN_TOOLS__ -MMD -MF .libxl_uuid.o.d -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  -Werror
-Wno-format-zero-length -Wmissing-declarations
-Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/libxc
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/include
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/libxc
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/include
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/xenstore
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/include
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/blktap2/control
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/blktap2/include
-I/local/scratch/xen-toolstack.git/tools/libxl/../../tools/include
-Wshadow -include
/local/scratch/xen-toolstack.git/tools/libxl/../../tools/config.h  -c -o
libxl_uuid.o libxl_uuid.c 
In file included from libxl_uuid.c:17:0:
./libxl_uuid.h:59:22: error: unknown type name âlibxl_ctxâ
libxl_uuid.c:38:6: error: no previous declaration for âlibxl_uuid_copyâ
[-Werror=missing-declarations]
cc1: all warnings being treated as errors
make: *** [libxl_uuid.o] Error 1


> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel