Re: [Xen-devel] [PATCH V5 04/32] libxl: libxl_uuid_copy now taks a ctx argument

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-16 at 12:28 +0100, Wei Liu wrote:
> On Fri, May 16, 2014 at 12:23:57PM +0100, Ian Campbell wrote:
> > On Fri, 2014-05-16 at 12:21 +0100, Wei Liu wrote:
> > 
> > > libxl_internal.h:56:3: error: #error libxl.h should be included via 
> > > libxl_internal.h, not separately
> > > libxl_internal.h:59:0: error: "LIBXL_EXTERNAL_CALLERS_ONLY" redefined 
> > > [-Werror]
> > 
> > I forgot about this. I think with this change you don't need the libxl.h
> > include in libxl_uuid.h. It is included either via libxl.h or
> > libxl_internal.h. 
> > 
> 
> I don't see inclusion of libxl_internal.h in libxl_uuid.h.

I mean that it is either:

libxl_foo.c -> libxl_internal.h -> libxl.h -> libxl_uuid.h

or 

xl_foo.c -> libxl.h -> libxl_uuid.h

Noone includes libxl_uuid.h directly (and it seems they shouldn't)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel