Xen project Mailing List

Re: [Xen-devel] [PATCH] xen: Use #defines instead of magic constants in vmx_vmcs_save()

From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

Date: Tue, 05 Aug 2014 15:26:48 +0300

Cc: eddie.dong@xxxxxxxxx, kevin.tian@xxxxxxxxx, keir@xxxxxxx, jun.nakajima@xxxxxxxxx, xen-devel@xxxxxxxxxxxxx

Comment: DomainKeys? See http://domainkeys.sourceforge.net/

Delivery-date: Tue, 05 Aug 2014 12:26:55 +0000

Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=g+8RghRpieHzekdRBq9sF0hbd3Kk+vHUtdqol8BpnGy86VeHSatpToajmbLGZHwisup3OlxJkh5VneCt8jbN0YMUWF/ySBzkV+JlQqGxGLhxypxnQLeVsoawoUmPR7m67y9waK5GDeiWWXVih7Q32/4YWvSTZvg028d+1xZJrUyYq7jSeOzADPzzHs2zqAH/HSwzyW27/sc+3CrOgrYinTfDAtb+n5lhnWxbC/Xwn6Q29XZgXdPI5C4ngddDfg2Gg/vz8VvNp12Zzlb9TO/MfjFvM0noGs2aoEzejTpThschDOfUDQkZCaifemkSUxFkmAg1mV9qySF3L1A8Wf49Wg==; h=Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;

List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 08/05/2014 03:04 PM, Jan Beulich wrote: >>>> On 05.08.14 at 11:57, <rcojocaru@xxxxxxxxxxxxxxx> wrote: >> --- a/xen/arch/x86/hvm/vmx/vmx.c >> +++ b/xen/arch/x86/hvm/vmx/vmx.c >> @@ -434,7 +434,8 @@ static void vmx_vmcs_save(struct vcpu *v, struct >> hvm_hw_cpu *c) >> c->error_code = 0; >> __vmread(VM_ENTRY_INTR_INFO, &ev); >> if ( (ev & INTR_INFO_VALID_MASK) && >> - hvm_event_needs_reinjection((ev >> 8) & 7, ev & 0xff) ) >> + hvm_event_needs_reinjection(MASK_EXTR(ev, >> INTR_INFO_INTR_TYPE_MASK), >> + ev & INTR_INFO_VECTOR_MASK) ) > > Broken indentation, but I guess I can fix this up while committing > unless the VMX maintainers dislike the change and don't give their > ack. No worries, I've sent V2: http://lists.xen.org/archives/html/xen-devel/2014-08/msg00471.html Hope it's right this time. Thanks, Razvan Cojocaru _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.