Re: [Xen-devel] [PATCH v4 1/1] Support Odroid-XU board (Exynos 5410)

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2014-08-25 at 15:06 -0700, Suriyan Ramasami wrote:
> On Mon, Aug 25, 2014 at 2:45 PM, Suriyan Ramasami <suriyan.r@xxxxxxxxx> wrote:
> > On Thu, Aug 21, 2014 at 3:21 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> 
> > wrote:
> >> On Tue, 2014-08-19 at 16:19 -0700, Suriyan Ramasami wrote:
> >>> @@ -64,11 +70,11 @@ static int exynos5_specific_mapping(struct domain *d)
> >>>      return 0;
> >>>  }
> >>>
> >>> -static int __init exynos5_smp_init(void)
> >>> +static int __init exynos_smp_init(paddr_t pa_sysram)
> >>> [...]
> >>
> >>> +static int __init exynos5250_smp_init(void)
> >>> [...]
> >>> +static int __init exynos5_smp_init(void)
> >>
> >> I'm not sure I grok the intending meaning/distinction of exynos5_* vs
> >> exynos5250_*. It *looks* like you are using exynos5_* for the 5410
> >> specific stuff, but I'm not sure (and I'm half suspecting that you are
> >> using it for both 5410 specific and more general things...).
> >>
> >> If that is the case then you really ought to be using exynos5410_* for
> >> stuff which is specific to that chip.
> >>
> >> Perhaps exynos5xxx_* would be less confusing for the generic stuff, but
> >> just avoiding using exynos5_* for 5410 specific stuff would be
> >> sufficient.
> >>
> > Thank you Ian for the review and suggestion. I shall use exynos5xxx_*
> > for generic and exynos5410_* and exynos5250_* names in my next
> > iteration.
> >
> I just looked at the code again. I do find that it I have consistently
> used exynos5_* for generic functions and exynos5410_* for 5410 specifc
> and exynos5250_* for 5250 specific functions. The function
> exynos5_smp_init(void) was moved down the file, and that is possibly
> causing some of this confusion (from a diff perspective).

Yes, that could well be what confused me, sorry about that.

If you can avoid moving the function, then great, otherwise then don't
worry.

> The exynos_* functions are helpers that have the same name as used in
> the linux tree to help in future backports as suggested by Julien.
> 
> Please let me know if this is OK.

From what you've said here it sounds like it, I'll take another look at
the patch, I'm terribly backlogged at the moment (vacation followed by
conference travel...)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel