Re: [Xen-devel] [PATCH v0 1/3] mem_access: modifications to mem_event enable API.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2014-08-22 at 22:05 +0000, Aravindh Puthiyaparambil (aravindp)
wrote:
> >4. The API xc_mem_event_enable is now modified to return int rather than
> >void *,
> >   this was done to synchronize this API's behaviour with other mem_event
> >API's.
> 
> FWIW, since I am the one that introduced this... I am fine with the
> change. Though I did think that the norm was to return -1 on error and
> set errno to the appropriate value.

Sadly there isn't really a norm in libxc now, we use basically every
possible way of returning errors.

In so far as we are moving in any particular direction to try and
rationalise this I think we are trying to get to set errno and return -1
(like a normal POSIXy library)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel