Re: [Xen-devel] [OSSTEST PATCH v2 10/12] make-flight: create XSM test jobs

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 10, 2014 at 05:00:15PM +0100, Ian Jackson wrote:
[...]
> > +  # xsm tests for versions > 4.4, arch amd64 and armhf
> > +  case "$xenbranch:$xenarch" in
> > +  xen-3.*-testing:*) test_xsm="n";;
> > +  xen-4.0-testing:*) test_xsm="n";;
> > +  xen-4.1-testing:*) test_xsm="n";;
> > +  xen-4.2-testing:*) test_xsm="n";;
> > +  xen-4.3-testing:*) test_xsm="n";;
> > +  xen-4.4-testing:*) test_xsm="n";;
> > +  *:amd64|armhf)     test_xsm="n y";;
> 
> I seem to remember this table appearing in a previous patch in this
> series, so now you have two copies of it.  Please have only one.
> 

I don't think it's right to make have only one. That would mean leaking
a global variable to another script.

It's a bit like test_xend in make-flight v.s. build_defxend in
mfi-common. I think changing test_xsm to build_xsm in mfi-common may
make things clearer.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel