[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC][PATCH 13/13] hvmloader/e820: construct guest e820 table

On 2015/5/15 16:54, Jan Beulich wrote:
On 15.05.15 at 10:47, <tiejun.chen@xxxxxxxxx> wrote:
On 2015/5/15 16:12, Jan Beulich wrote:
On 15.05.15 at 10:00, <tiejun.chen@xxxxxxxxx> wrote:
On 2015/5/15 15:34, Jan Beulich wrote:
On 15.05.15 at 09:11, <tiejun.chen@xxxxxxxxx> wrote:
On 2015/5/15 14:56, Jan Beulich wrote:
On 15.05.15 at 08:39, <tiejun.chen@xxxxxxxxx> wrote:
On 2015/5/15 14:25, Jan Beulich wrote:
On 15.05.15 at 08:11, <tiejun.chen@xxxxxxxxx> wrote:
Even we may separate the
low memory to construct memory_map.map[]...


Sorry I just mean that the low memory is not represented with only one
memory_map.map[] in some cases.

That's correct.

So just lets keep that original BUG_ON()?

In your previous reply you seemed to agree that the BUG_ON() is
becoming meaningless. Why do you now suggest to keep it then?

Sorry just let me clear this.

We still need to check this,

(hvm_info->low_mem_pgend << PAGE_SHIFT) < (2u << 20)

Right? I agree the original is really less relevant as you said.

And I didn't ask you to drop it. All I asked it to amend it with another
BUG_ON() checking what the one above won't cover anymore.

Another point hits me in this case while we're discussing MMIO in
another email.

We may populate RAM to get enough MMIO in pci_setup() so this means
hvm_info->low_mem_pgend would be changed. Furthermore, low_mem_pgend
isn't going to keep recording our original lowmem while building domain.
So I think this original BUG_ON() is still good to cover this case. But
obviously, we need to adjust its associated memory_map.map[x] right now.

So what about this?

I don't think I have enough context anymore of all the other changes
that you have pending to be able to reasonably judge on such code
fragments. This will need looking at in the context of the next patch
series revision.

Okay. Currently I'm still addressing some comments from tools maintainer. Once that is fine enough to step next, I'll send out next revision.

Thanks for your review.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.