[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v8.1 17/27] xsplice: Add support for bug frames.



>>> On 22.04.16 at 12:54, <konrad.wilk@xxxxxxxxxx> wrote:
> The thing that makes it "safe" (in lieu of your comment about
> re-ordering) is that the trap code does:
> 
> 1289     /* WARN, BUG or ASSERT: decode the filename pointer and line 
> number. */
> 1290     filename = bug_ptr(bug);
> 1291     if ( !is_kernel(filename) && !is_patch(filename) )
> 1292         goto die;
> 
> Which means we first try 'is_kernel'. Since the list addition cannot be
> part of the payload it will always be part of the hypervisor.

I'm sorry, but no. The bug hit (and hence the referenced file name)
may be in some other payload, requiring list traversal.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.