[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 09/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending

Hi Quan,

On 25/04/2016 15:50, Xu, Quan wrote:
On April 25, 2016 9:58pm, <julien.grall@xxxxxxx> wrote:
On 25/04/16 12:52, Jan Beulich wrote:
On 18.04.16 at 16:00, <quan.xu@xxxxxxxxx> wrote:
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2540,7 +2540,7 @@ static int force_stage = 2;
   static u32 platform_features = ARM_SMMU_FEAT_COHERENT_WALK;

-static void arm_smmu_iotlb_flush_all(struct domain *d)
+static int arm_smmu_iotlb_flush_all(struct domain *d)
        struct arm_smmu_xen_domain *smmu_domain =
        struct iommu_domain *cfg;
@@ -2557,13 +2557,15 @@ static void arm_smmu_iotlb_flush_all(struct
domain *d)
+    return 0;

Even if indentation looks inconsistent in this file, please make your
addition match surrounding code.

The file smmu.c was imported from Linux and supposed to use only Linux
coding style. This is in order to help porting fixes.

  Julien,  A 'tab'  ?

Yes, Linux is using hard tabulation for the indentation.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.