Re: [Xen-devel] [PATCH RFC v7 07/14] efi: create new early memory allocator

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.09.16 at 19:49, <daniel.kiper@xxxxxxxxxx> wrote:
> On Mon, Sep 26, 2016 at 07:37:45AM -0600, Jan Beulich wrote:
>> >>> On 23.09.16 at 23:47, <daniel.kiper@xxxxxxxxxx> wrote:
>> > --- a/xen/common/efi/boot.c
>> > +++ b/xen/common/efi/boot.c
>> > @@ -79,6 +79,10 @@ static size_t wstrlen(const CHAR16 * s);
>> >  static int set_color(u32 mask, int bpp, u8 *pos, u8 *sz);
>> >  static bool_t match_guid(const EFI_GUID *guid1, const EFI_GUID *guid2);
>> >
>> > +#ifndef CONFIG_ARM
>> > +static void *ebmalloc(size_t size);
>> > +#endif
>>
>> Leaving aside the ARM aspect (to be clarified by Julien), is there a
>> reason you need to forward declare this here, rather than moving
>> the whole addition from further down up immediately ahead of the
>> inclusion point of efi-boot.h?
> 
> If you wish I can move ebmalloc code before efi-boot.h inclusion.
> There is a pretty good chance that it will work here.

Yes please, the more that Julien now confirmed that he's fine
with the code staying in common/efi/boot.c.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel