[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v6 16/16] libxl/arm: Add the size of ACPI tables to maxmem
Hi,
On 28/09/2016 06:17, Wei Liu wrote:
On Wed, Sep 28, 2016 at 06:11:53AM -0700, Shannon Zhao wrote:
libxl__get_acpi_size(gc, info, gic_version /* not build_state anymore */)
/* also fix up libxl__estimate_madt_size */
/* this is the function called when constructing the domain etc, only
* in libxl_arm.c */
static acpi_extra_memory(gc, build_info, gic_version)
{
libxl__get_acpi_size...
}
libxl__arch_extra_memory(gc, d_config)
{
gic_version = d_config->..gic_version;
If user doesn't specify gic_version in xl config, the
d_config->b_info.arch_arm.gic_version will be LIBXL_GIC_VERSION_DEFAULT, so
we can't know the exact gic_version which will be constructed later.
First, can you confirm if it really can't be retrieved?
libxl__arch_domain_save_config updates that field after the domain is
constructed, so you might have a determined gic version to hand.
The target memory of the domain is created after the domain has been
created. So we should have the correct GIC version is hand.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
