Re: [Xen-devel] [PATCH v2 10/30] xen/x86: allow the emulated APICs to be enbled for the hardware domain

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.09.16 at 17:57, <roger.pau@xxxxxxxxxx> wrote:
> +static bool emulation_flags_ok(const struct domain *d, uint32_t emflags)
> +{
> +
> +    if ( is_hvm_domain(d) )
> +    {
> +        if ( is_hardware_domain(d) &&
> +             emflags != 
> (XEN_X86_EMU_PIT|XEN_X86_EMU_LAPIC|XEN_X86_EMU_IOAPIC))
> +            return false;
> +        if ( !is_hardware_domain(d) &&
> +             emflags != XEN_X86_EMU_ALL && emflags != 0 )
> +            return false;
> +    }
> +    else
> +    {
> +        /* PV or classic PVH. */
> +        if ( is_hardware_domain(d) && emflags != XEN_X86_EMU_PIT )
> +            return false;
> +        if ( !is_hardware_domain(d) && emflags != 0 )
> +            return false;

Previous code permitted XEN_X86_EMU_PIT also for the non-hardware
domains afaict. You shouldn't change behavior without saying so and
explaining why.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel