Re: [Xen-devel] [PATCH v6 09/14] arm/guest_access: Move vgic_access_guest_memory to guest_access.h

[Sergej Proskurin <proskurin@xxxxxxxxxxxxx>]

On 07/18/2017 02:12 PM, Julien Grall wrote:

>
>
> On 18/07/17 12:59, Sergej Proskurin wrote:
>> Hi Julien,
>>
>>
>> On 07/18/2017 12:43 PM, Julien Grall wrote:
>>>
>>>
>>> On 18/07/17 10:49, Sergej Proskurin wrote:
>>>> Hi Julien,
>>>
>>> Hello Sergej,
>>>
>>>>
>>>> On 07/17/2017 05:38 PM, Julien Grall wrote:
>>>>> Hi Sergej,
>>>>>
>>>>> On 06/07/17 12:50, Sergej Proskurin wrote:
>>>>>> This commit moves the function vgic_access_guest_memory to
>>>>>> guestcopy.c
>>>>>> and the header asm/guest_access.h. No functional changes are made.
>>>>>> Please note that the function will be renamed in the following
>>>>>> commit.
>>>>>>
>>>>>> Signed-off-by: Sergej Proskurin <proskurin@xxxxxxxxxxxxx>
>>>>>
>>>>> Acked-by: Julien Grall <julien.grall@xxxxxxx>
>>>>
>>>> Through Travis CI, I have noticed that clang had troubles compiling
>>>> the
>>>> source, as it missed some types in  guest_access.h. I fixed it by
>>>> including <xen/types.h> in guest_access.h. With this change, may I
>>>> keep
>>>> your Acked-by or remove it in the next version?
>>>
>>> I can't tell whether this is the right thing to do without seen the
>>> error commit message.
>>>
>>
>> I have just removed the upper include from guest_access.h to reproduce
>> the mentioned errors. To my surprise, Travis works right through without
>> generating any issues; it did though last week. It is likely that the
>> mentioned issues from last week have been provoked by my tests, which I
>> have not immediately recognized as such. I am very sorry for the noise!
>>
>>> But I am a bit surprised that Travis CI is trying to build Xen ARM
>>> with clang...  Last time at looked at it, I remember some missing
>>> patches in Xen to use clang.
>>
>> I recently startet using Travic CI with Xen again and was also surprised
>> that it worked with clang as well. I remember having troubles with it
>> about 6 months ago.
>
> Well clang is well supported for Xen x86. But for ARM... I would be
> interested to see the full logs, clang version, and whether it
> cross-compile.

Sorry for the misunderstanding: As you said, Travis CI uses clang only
for x86 atm. Which is especially strange that I got issues last week, as
this patch does not touch any code that is shared between ARM and x86. I
can't explain it right now. Again, sorry for the noise.

Thanks,
~Sergej


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel