Re: [Xen-devel] [RFC 11/16] irq: skip action avalability check for guest's IRQ

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

On 12.12.18 16:49, Julien Grall wrote:
> ASSERT only tells you that desc->action was NULL. It does not tell you which IRQ 
> has the desc->action == NULL.
Ah, yes.

> It is a bit a shame we don't have way to provide another message with ASSERT to 
> help you debugging.
We might have implemented an assert with a message.
And guys on stackoverflow suggest for workaround `ASSERT(condition && "error 
message")`.

> No, I am suggesting to have the current if ( test_bit(...) ) protecred with 
> #ifndef NDEBUG. No code duplication.
I would not like to leave even non-debug build without the check.

--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel