[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 11/16] irq: skip action avalability check for guest's IRQ

On 12/12/2018 14:58, Andrii Anisov wrote:

On 12.12.18 16:49, Julien Grall wrote:
ASSERT only tells you that desc->action was NULL. It does not tell you which IRQ has the desc->action == NULL.
Ah, yes.

It is a bit a shame we don't have way to provide another message with ASSERT to help you debugging.
We might have implemented an assert with a message.
And guys on stackoverflow suggest for workaround `ASSERT(condition && "error message")`.

That's not going to help for showing the IRQ number.

No, I am suggesting to have the current if ( test_bit(...) ) protecred with #ifndef NDEBUG. No code duplication.
I would not like to leave even non-debug build without the check.

The check is mainly there to catch error in debug build. So I am quite confused what is your goal by moving the check. Is it just because it adds a couple more instruction in the guest case?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.