[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Continuing the Gitlab experiment: Single-patch PRs for gitlab


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Fri, 4 Sep 2020 12:47:38 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vB4G5DwbZk1WbD++IQcduL+CGvSv9yehnnhdE+ZDBW8=; b=dfhvu5uFoVSge0Q7WwAFdSgfgQ1niFJKu2WW/Akyn48xP3Azskk/ZZY755EgDDFlp6OiUzTRyNZGMW6AVomg1jeqp10Z7XHGQetJZVUL1cSasz/4B3zeNRSiMHgzuv3yEVlzY9f6DzqV7Ph/yPKtxpPYizMg7RGz9yhVJfxPY/e5QWkFMcRYe1f4Y488e3NGxpC66Ya+Iorn+jDMH1h1uGQhLiDCPuf2lMU2cMUk7uWx9P0Y66B7urRjejNCj5Vt+9l2GeU29v6GqwQzb0Ap5hOt+5/Ar2pXcFy81KFa45aXl6Vw7uEUFL2J2ie+BZ85vcuPxIQ3O6eKFdcNgCSTbg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iuRy7S0c2sG7Qc0WzjJWgoqfgrSFw/2jZaJmRE20QxBA4NCFgRjldxFfT6pnaglIR6zBMRwHnuVAW7B/39Eyo4As8jljaNxJJtnRyWy8MKv5XQNeTBrvvhNpL8r1dBxjhExpcj4EifxsEMkbisNTIHGGgXYCHeo8gzHOVteTQXPoVCqQ1SYhdUMPxUSZxXdTYyEdJcKfMarZ/vCMSK3sNG/hWXOz6c+Tuwhnz0KVW5u5XIz1d/5YtZ/8OP9Jwa2mEJphEN3duAybY3i1RfymNkrIJEQK8bGPlHUWPHzH1k8MejhQcTApn6pk+l1j7i5B/OhWWQY9gvsM1OlWXArztA==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 04 Sep 2020 12:47:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWgqFQIv5YQfrx8UWhPeAs1v6hhqlYRMuAgAAGaQCAACE7AIAAAXCA
  • Thread-topic: Continuing the Gitlab experiment: Single-patch PRs for gitlab


> On 4 Sep 2020, at 13:42, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 04.09.2020 12:43, Bertrand Marquis wrote:
>>> On 4 Sep 2020, at 11:20, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> 
>>> On 04.09.2020 11:54, George Dunlap wrote:
>>>> At the community call last month as well as this, we discussed whether to 
>>>> continue the “Gitlab experiment”.  It was generally agreed that reviewing 
>>>> Juergen’s long series was fairly sub-optimal, and that email was more 
>>>> suited to that sort of series.
>>>> 
>>>> That said, there was general agreement that requiring all patches to go 
>>>> through email was going to limit contribution, particularly of one-off 
>>>> “drive-by” contributions.  As such, it was proposed that we consider 
>>>> allowing both Gitlab PRs, and email: that for one-off or short series, 
>>>> Gitlab PRs would be accepted, but that for longer series and/or longer 
>>>> term contributors, we would encourage people to switch to patchbombing the 
>>>> mailing list.
>>>> 
>>>> We decided to continue the “Gitlab Experiment”, but with short PRs.  As 
>>>> such, Andy Cooper has posted two PRs:
>>>> 
>>>> https://gitlab.com/xen-project/xen/-/merge_requests/2
>>> 
>>> This looks to be confusing, to me at least. Following this link I
>>> can't see the actual change directly. Following either of the links
>>> after "Request to merge" gives a 404 error (after gitlab not being
>>> able to sign me in via Google, but then being able to sign me in
>>> via github) on both
>>> 
>>> https://gitlab.com/xen-project/people/andyhhp/xen
>>> https://gitlab.com/xen-project/people/andyhhp/xen/-/tree/xen-pv-segbase
>> 
>> I think you missed on top the “Commits” and “Changes"
> 
> I did indeed. Nevertheless I think the other links ought to be
> working, as they're (I assume) going to give me a view of the
> tree as a whole with the patch/series applied.
> 
> That said, from an engineer's point of view I think the main
> thing of interest should be shown in the "primary" view, and
> that's (imo) clearly the entire patch.

If you look at the serie sent by Trammel this is a bit more clear:
- overview is for global comments
- commits list the different patches of the serie
- when you click on a commit you see the diff for this commit and you can 
comment

Having everything on one page would fit for a small patch but for a serie that 
would be to much.

I agree though the interface could be better but maybe we just have to get used 
to it.

Cheers

Bertrand

> 
> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.