[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Continuing the Gitlab experiment: Single-patch PRs for gitlab
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Fri, 4 Sep 2020 14:57:19 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BV2byaCTwexqkeSlxRJwku7ZKKhtUPCnd6fJyurco0Y=; b=XBJyfvToKeG9aBVT8VtI8HMRqfHxxz4VVakKbUIbPiFVQB52SyqSuDUQvyalltohg0znBYZsqApxx/DxlzgcbJ7Gx4XHzAoq+qbPnF0hesH2fqMJp0iq0sf8dXB+BYcSY0NTVyqoAXDFq6g+ZexZIMc6MkEM0IcOH00N+ps50JJHLpTOXxmcioi3mddUT9AG4BuWMwoQkq4r4/txy0hzO5oUtRRrBwwNxIVOG8PHMuxyrt6mq1+uAKjOczGON8DV33Pkm7xMVBcbQbk/oEtbFrIDoVn9ia+0nYCyvd2CufIfSPPEg5VBA/dP3mgbL/mz92Xeqjol9OL2bJ1vO61bwg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vr5ayc+IhQkKHGCOA6kTgytvYjUZ2wtXVBUc2eRNafhPY8PLoU9OGOfKn8zZiALvQcmEOcdZhMtWfmSmTpz5THU2yNwmfph/HXDTbDzMW8xMUHU6NskKBEghdDeEz6eb5d629hKy/wVMJeQqvCz29F2fsiRA0o3h9DhJLNWFu4lA1YBk2rpl64Gy02nCVIe1xeHjsEsZgamjv9/gpi8c/GUZ6mqJKtvHhR/iZYm79gOsHNCUaX4Q80IlkCT0PoZ8o2kfs/d7rlg+39kh2X4dQJLVgN/8VRTsnzQUPezTUmkpVdWce3oP/uhCLavA6ESbf+xfTjyLijUWsemhsSZ+iQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 04 Sep 2020 14:57:36 +0000
- Ironport-sdr: GV2reJ0t3zg6LiTfO05SiMe+BqGxDhkoLR2bpyhSZITqn26AQQM6knry0cz4OWCbdB5ksKzUjj kKbUVrHO0wf9t3sl2cYczx5jmFlDGerpNVzU2w7Eq3VhsXVgS1FAyKsKqMPOYDBDyO79JfPrLF CmQPYUEKcY1T8A9FGqFb9t712nBlVRPajVpABClH8VfpvhyeYpO6VWSY/T/0YDEkxvQjmBrP5m rUzo40qcnm8+6ngaLkoz4D316TxCW+DAPdn/HnCrUopPs6l7cPUTdQ2eqtnKaS46fXyZto3tsY 2cg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWgqFQhHT7mTtQgECZKsLV4pzAaalYRMuAgAAGaQCAAAHFAIAAANWAgAAA5YCAABBzgA==
- Thread-topic: Continuing the Gitlab experiment: Single-patch PRs for gitlab
> On Sep 4, 2020, at 11:56 AM, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
> wrote:
>
>
>
>> On 4 Sep 2020, at 11:52, George Dunlap <george.dunlap@xxxxxxxxxx> wrote:
>>
>>
>>
>>> On Sep 4, 2020, at 11:49 AM, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
>>> wrote:
>>>
>>>>
>>>> I tried to add a comment and that is working well
>>>>
>>>> Remarks from my side:
>>>> - How can i ack/test/reject on this ?
>>>
>>> answer myself as i found the thumbs up that i have to click :-)
>>
>> I have a button that says “Approve” — do you not have that? Perhaps you
>> don’t have the requisite permissions.
>>
>> But I think adding “Reviewed-by” in a comment would work just as well.
>
> When you add a comment at the end you can say “Finish review”, maybe that one
> is the “Reviewed-by”.
> We might need to check if gitlab is not adding those automatically somehow.
At the moment we’re not going to use the gitlab merge functionality.
Fundamentally there has to be one “canonical version”, and at the moment that’s
the xen.git on xenbits. Committers will have to do a manual pull & push,
adding tags manually (as they do now for the mailing list).
-George
|
