Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

[Ian Jackson <iwj@xxxxxxxxxxxxxx>]

Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree 
node in libxl [and 1 more messages]"):
> On 14/10/2021 18:54, Ian Jackson wrote:
...
> > That is, as I understand it on ARM vpci should be enabled if
> > passthrough is enabled and not otherwise.  That is precisely what
> > the variable c_info->passthrough is.
> 
> On Arm, c_info->passthrough is also set when assigning platform devives 
> (e.g. a non-PCI network card). At least for now, we don't want to create 
> a node for vCPI in the Device-Tree because we don't enable the 
> emulation. So...

Oh.

> > 3. Now you can use d_config->c_info.passthrough to gate the addition
> >     of the additional stuff to the DT.  Ie, that is a respin of this
> >     patch 3/3.
> 
> ... we will need to check d_config->num_pcidevs for the time being.

OK.

Can you leave a comment somewhere (near where c_info.passthrough is
set) pointing to this use of num_pcidevs ?  That might save someone
some future confusion.

Thanks,
Ian.