[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]

Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree 
node in libxl [and 1 more messages]"):
> On 15.10.2021 12:02, Ian Jackson wrote:
> > Can you leave a comment somewhere (near where c_info.passthrough is
> > set) pointing to this use of num_pcidevs ?  That might save someone
> > some future confusion.
> Here, c_info->passthrough is set to enabled if either d_config->num_pcidevs or
> d_config->num_dtdevs is set. Do you think we need to add there additional 
> comment?
> If so can you please help with what should I write there?
> BTW. None of the patch I'm preparing with regards to this discussion modifies 
> libxl_create
> where c_info.passthrough i set. Do you still want me to add some comment 
> there?

Yes, I think so.  I won't insisting on it if you feel it doesn't make

Maybe something like

  // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
  // decide whether to enable vpci, rather than using c_info->passthrough.
  // This will be insufficient if and when ARM does PCI hotplug.





Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.