[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 21 Jul 2023 16:24:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=upfyQASg5GCgFNr8NCwv5iw6jg70UGhBI6DsBqE85rQ=; b=hKa/AaRTCqxWg3rNuI80wpFjptkcs6BIeDg51oQPEOITSBVbVduKCjYPiaLsdAL9FhUGLQ2Ty+jc6FVRGIo7/eRcqUvH4elQRVTGb3UVL30GCoSFxIyd2oKUtLLWx1toS/uLafFTGx9iaj/T27EfwGLJMIy+Aa7DXrFq8bUU6XTamy3c2ppyQ+diIXmgUjStnGZJkpjmZnfpmGWGMBgpZxWR0WZ49R6l0hybQJpYEPF32QvyU/xSUYuLdJOoG1vLiqn3X9pk8FKWJ/Ua8826fLAWSrQc9J0jxmgdQQwOhSt5UviWktYu7iNTF0V4yiwnhq+pcKHUZi57Os1QATfycQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QdDKkaYMTSiYuOm/17RdPNTeAETc5rBjlbCKnss4TTR91Ai1ErQAwedEOGO51qz2Rhb1Z08MbmpejuX7AxJ2Ttc9oGjKEwDAILVaqZiSuWeZPanG0aOA7boH2FHrn5t3fiFKElfpOcMpflonE41yvMhYEtOuE/7Lcu0G1DpyjtR82UttCRBulw6wMClrnoTbN3OzOygn/SgMNk5zQAMG7Mt7eKSuRzB8ChHvaRQ4/RxYilWnDMAl2qvqU8ILe8EbX7zxgFyS0WS8WoL1kUnhNSd+PGlbAHsqy4DLY0DlkCVxsTn25CQMCHfGExHwxKm+hNcPwftDJx8vdcN1fw+nGQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 21 Jul 2023 14:24:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.07.2023 16:07, Bertrand Marquis wrote:
>> On 21 Jul 2023, at 15:08, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 21.07.2023 14:27, Bertrand Marquis wrote:
>>> So what should i keep or remove here ?
>>
>> My understanding so far was that "visibility" merely hides all prompts
>> underneath (but then I use the command line version of the tool, not
>> menuconfig), so it largely is shorthand for adding "if" to all enclosed
>> prompts. Therefore I think all the "if UNSUPPORTED" are redundant and
>> could be dropped. But then I'm also working from the understanding that
>> "depends on" would behave somewhat differently ...
>
> If that is ok with you I would rather keep them so that making one of them
> SUPPORTED one day will not end up in wrongly making the other one
> supported to. The visible if i added was more to "beautify" a bit when
> unsupported is not selected so that we do not have an empty menu.
You're the maintainer, so you judge what is best. If I was maintainer, the
primary thing I would ask for is that there be no redundancy. IOW here
either no "if"s or no "visibility".
Jan
|
