[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 21 Jul 2023 14:34:15 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZCMC/vszV1gc2aSIVmW1r2fT1riDnMdaiaIthroaFA=; b=Zf1+Bg0qoH5evzqY8/u2MlWAFsSvcCXvQmmuvpz4rLXBwBpETgCMllW8UUo7JBBS7l0mLvdg2GzL4HPM28HJEJ1Ocq2Ew6L1PAfszQmOxTwKcxRD7XA84KlALsA132ebLtJft4fGfPeQUOWhFXUozHkQEUqajj7JleSRJbLsAuKGi76HTbNq2OYqHXHRSrUBRx91RY0YXq9moVgWT7nSkOyN/OEuBgtoyGiSwQE706DFG+zZnN6tcgxG8QMWbdHUajW9gBBHDUOQYM9tbel+H95VQLZYvqfBt2Q+ZHMeVSqf9iToLVDvXA0gmicLHK9M0trBiq2FokqnX5n4EnslyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HXJeofWsZQL0Zqk9PaITS34vAakyyb18WEIh5l4Aq50srB8XnEdFhif2nnw7f8ywiSJlzOfshXIm8Nf4vSU4eSjcjE1FhD5ytzxPR+RhfbuWgd7R8crxlHQbkAvzhoGV6zKVKwiI0UJM88rwXiMs7QAeQywwm+2JKtFU90TFg/IC8/ATbiIfC5dLqFSkJRjPScB/1opX/8Gv1QZ0Fr3u0M3GzIBG6+1sCKM/oaT439mNfxfSQBTvm1EdSLVytH3QomVYhx6qsGI1bJDzU5ytyGnZTTiCxQ318pyFXkC23JyJapRG/rJNFvmhgGBnXrIARDMutbzKU7kG9WJbKL4vLA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 21 Jul 2023 14:34:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZu6nFJdPelAC9nE2wzAZF/5qPkK/D6iMAgAACsoCAABzbgIAAHFKAgAALbgCAABCjAIAABLWAgAACsAA=
- Thread-topic: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu
Hi Jan,
> On 21 Jul 2023, at 16:24, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 21.07.2023 16:07, Bertrand Marquis wrote:
>>> On 21 Jul 2023, at 15:08, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> On 21.07.2023 14:27, Bertrand Marquis wrote:
>>>> So what should i keep or remove here ?
>>>
>>> My understanding so far was that "visibility" merely hides all prompts
>>> underneath (but then I use the command line version of the tool, not
>>> menuconfig), so it largely is shorthand for adding "if" to all enclosed
>>> prompts. Therefore I think all the "if UNSUPPORTED" are redundant and
>>> could be dropped. But then I'm also working from the understanding that
>>> "depends on" would behave somewhat differently ...
>>
>> If that is ok with you I would rather keep them so that making one of them
>> SUPPORTED one day will not end up in wrongly making the other one
>> supported to. The visible if i added was more to "beautify" a bit when
>> unsupported is not selected so that we do not have an empty menu.
>
> You're the maintainer, so you judge what is best. If I was maintainer, the
> primary thing I would ask for is that there be no redundancy. IOW here
> either no "if"s or no "visibility".
In this case i do think that the "if UNSUPPORTED" per entry is important
so that it clear per config entry which ones are unsupported.
So if other arm maintainers agree with your point, i would remove the
"visibility" and keep an empty menu.
But my vote is to keep both.
@julien and Stefano: Any view on that ?
Cheers
Bertrand
>
> Jan
|
