Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu

[Julien Grall <julien@xxxxxxx>]

Hi,

On 21/07/2023 15:34, Bertrand Marquis wrote:
> > On 21 Jul 2023, at 16:24, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >
> > On 21.07.2023 16:07, Bertrand Marquis wrote:
> > > > On 21 Jul 2023, at 15:08, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> > > > On 21.07.2023 14:27, Bertrand Marquis wrote:
> > > > > So what should i keep or remove here ?
> > > > My understanding so far was that "visibility" merely hides all prompts
> > > > underneath (but then I use the command line version of the tool, not
> > > > menuconfig), so it largely is shorthand for adding "if" to all enclosed
> > > > prompts. Therefore I think all the "if UNSUPPORTED" are redundant and
> > > > could be dropped. But then I'm also working from the understanding that
> > > > "depends on" would behave somewhat differently ...
> > > If that is ok with you I would rather keep them so that making one of them
> > > SUPPORTED one day will not end up in wrongly making the other one
> > > supported to. The visible if i added was more to "beautify" a bit when
> > > unsupported is not selected so that we do not have an empty menu.
> > You're the maintainer, so you judge what is best. If I was maintainer, the
> > primary thing I would ask for is that there be no redundancy. IOW here
> > either no "if"s or no "visibility".
> In this case i do think that the "if UNSUPPORTED" per entry is important
> so that it clear per config entry which ones are unsupported.
>
> So if other arm maintainers agree with your point, i would remove the
> "visibility" and keep an empty menu.
> But my vote is to keep both.
>
> @julien and Stefano: Any view on that ?
I agree with keeping both.

Cheers,

--
Julien Grall