[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3] xen/spinlock: mechanically rename parameter name 'debug'
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 27 Jul 2023 09:22:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ajb5dH+/30TDlvLOwU6kzYci+WIhf1DmlNaqP1u90xE=; b=PV5Jd62DfAtzCdmInoFqz7jJyYafa69f/LP90BTWehnOpDe0K4GP1HwU8ygnnpCis8kzYnGJoBOgkenB2/K2lQOT5eDP+oMIjk9Re0kmEEYgnIfzL+jLTPCmWL+S2SQi1URcpkE0Fu2MCJHi4Msq/1zbCLI1mgUtkZgou00QZTvgtLRpV0O2SRFPh0NH/s/DJI7aoEXzOpnqkkwAVEGV27vkOBx5Yxb8cgejpIrp1aFwiqsLbw7LUxO8El272va7pmtJ1u99DQyUncyguvKEajecimmbTzbrSNcKRiGvCYjJsOvUqRYfjwe9WejNoTuA9942G4kqWXMCxf+uBA687Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y06UicKAxexGybne+xN5TTm0Kdy8R7BCfk/hahTmj9ml1+KsqsEzn5AD3bNSazWkv7dHWzDOt0R5+FoWWq8wJELVH3GxILBFoVaSulkvM518Mxg4jRdPZ+7O6ezEh0ZQSKOJqjCw6hZn57rpPW5zkOYvF7iTmRLm1IPG8vbePjd5npnZqbCxf4lzS+BOx3bJOqU9rtVJhiEgtNIzWzKsKG3RysDrjOJJamGJIeIeg9xXv5yR3CzzArF6ANr31h4mZ3+KNlNaqJfPGNzsWvRe23SxHc3KuaCBviAcOfs2CCpivEaP7p1asTNOJJeVV4hijNQImxtMepHD2AMkiVQWcg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 27 Jul 2023 07:23:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.07.2023 23:49, Stefano Stabellini wrote:
> On Wed, 26 Jul 2023, Jan Beulich wrote:
>> On 26.07.2023 08:42, Nicola Vetrini wrote:
>>> On 26/07/23 08:34, Jan Beulich wrote:
>>>> On 25.07.2023 22:45, Nicola Vetrini wrote:
>>>>> Rule 5.3 has the following headline:
>>>>> "An identifier declared in an inner scope shall not hide an
>>>>> identifier declared in an outer scope"
>>>>>
>>>>> To avoid any confusion resulting from the parameter 'debug'
>>>>> hiding the homonymous function declared at
>>>>> 'xen/arch/x86/include/asm/processor.h:428'
>>>>> the rename of parameters s/debug/lkdbg/ is performed.
>>>>>
>>>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>>>> ---
>>>>> Changes in v2:
>>>>> - s/dbg/lkdbg/
>>>>> Changes in v3:
>>>>> - Added missing renames for consistency
>>>>
>>>> Hmm, you asked whether to send v3, but then you didn't wait for an
>>>> answer. So to repeat what I said there: I'd prefer if we could first
>>>> settle whether to rename the conflicting x86 symbol.
>>>>
>>>
>>> Stefano replied asking for a v3 [1] before I had a chance to read your
>>> message this morning.
>>
>> Right, sorry, I spotted his reply only after seeing the v3.
>
> For what is worth I prefer the current implementation compared to
> renaming debug()
I don't. My replacement name suggestions were only "just in case"; I
don't really like them.
Jan
|
