[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 10 Nov 2023 09:30:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5enDbHKeOspL9dlEtYf6mrz5pcNhPPasm7en2wriDG0=; b=II3D0LV9bDtU1gsxjGLKseaDn8f5oD/wBrE9Ufi5w6pMdux7yoaUrAkTY+7NIsCu9p4C+0725RoXx8u2WUfk3McstQNLw5qiVgFpI0MEQctwhWuVG0TA2FaXCbmPZsq9gR0pzQQhrquo58fXi4ReK5QD0eJH4/fQ8oUP0/49c/anHxVElG39NQCrtiMsQwTxAg92+fIiSia5ZA1irJhTQpwdnh1G4LpimEirG7FkxAviT7RmhH3Orx5UwIvf7NNcHl3eWvHcMepBNmFAM0QH2/82cuBD3XTivF3yqMJ/7vbrIAEcJVmL6GRosHvibMYJKMFD4n7ReXOseA5vzNvwLw==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5enDbHKeOspL9dlEtYf6mrz5pcNhPPasm7en2wriDG0=; b=iFrmht6ShkLjDr9Wunx7x/FCvG0avgG7jj+lphasR1lvSUyGSSGtqxI+uMOQsurGMGkUAHDLRnI73ao8Fo/mjiAGIgS5g85iRJKqJXWcLnayz9eJLGUqah+Uvlw/jOEZPTMQZvv9AwioQpYE5lsw2thSz3sdTNj0WaLUh7jDGbtRdO2CtGfoDfxoXUktN9oO7xzm2lOO2CgW5w1G2FJ76aS55YzMeQZmcWPyaIQMwDDefLjFr65IW27DdHytMlzWDKgXaorLzrNSLgkN4XPsKWCKNrCCDQJg41Pv6zKX3EPuwd2SfJjAjBldfEutKP1j2123Ad/rrhzdu8qqN/6NRw==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AGLkVhUeJOW5wLlsEGIEGvbDns55trcJOQoCzbFHFAODyB8rMLbSx+z6pVJRWMywXUfp57OVhBNJ9RM0Bmt+7YrtskYcrt+gMdh190XI9u/KchJSoM2ndLXc2wWbJX9HjsDob7f656CUx/vGosmsg5aE7awkP5nXMkVuBF+L+IQ5CdraokJ1zd2vzsjsRDyP6sgnAD8WKsZsEKrtLNGeqm/WL8oTB3n6FnQWw2PyizjIazNB/4Q5Ke4aKmh5sOt+qMADhE05RlmB9Me4elLUxWAtjzLiiDWFdvKpwhNQShCqQs0d8Cha2ZvzRwW9j8HTeAs70gG0gZIopaJjgf0DLw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C3T/8RnMG0XMxiNVDH2SPmi837XD1pFsFH2t2A8iy5Q1gQa2KB6y3GQWojb9DLCa7CGTqviBbT5yVIEN7WFGHaAxOsPF0LDiXBTuCcg/4zB8JspLbZUX81lUOjNS9Cph+uVdkTsh9wMUNmxlhNMw0Hubvmqa1EkoFLp04lOJ3YH0gRam9S0rEjJ7lzmnN7YTOvB8Hvt0sCSwDZhzJs2ail5wJcQRMYixDcqeDOxPf0ykqUHJRxdo8NVqoL6C9RsF8SAqzwInr9J7WwzGY8IGbWjREheHQLsBVBJoIOVyQwzckKa1zGkCUmxv+Q7TR1pSZFKdpk/uCrv5CbhKQ+lhPw==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 10 Nov 2023 09:30:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHaEuwVAcRvSKcty0WG4JBMWUF0b7BzQ0WAgAABDgCAAAbKAA==
  • Thread-topic: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature


> On 10 Nov 2023, at 09:05, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
> 
> Hi Michal,
> 
>>> 
>>> +config DOM0LESS_BOOT
>>> +       bool "Dom0less boot support" if EXPERT
>>> +       depends on ARM
>> You're in the Arm Kconfig, so there should be no need for this dependency 
>> (it is implicit).
>> 
>> Apart from that, we have 2 features: static mem and static shmem that are 
>> only meant for dom0less domUs.
>> Shouldn't we make them dependent on DOM0LESS_BOOT? Otherwise, what is the 
>> purpose of selecting them
>> with DOM0LESS_BOOT=n?
> 
> Sure, I’ll add the dependencies and remove the ARM one

Just to be sure, is it what you are asking?

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 0399f2faf734..d9c5340ff3a2 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -90,7 +90,6 @@ config GICV2
 
 config DOM0LESS_BOOT
        bool "Dom0less boot support" if EXPERT
-       depends on ARM
        default y
        help
          Dom0less boot support enables Xen to create and start domU guests 
during
@@ -214,7 +213,7 @@ source "arch/arm/tee/Kconfig"
 
 config STATIC_SHM
        bool "Statically shared memory on a dom0less system" if UNSUPPORTED
-       depends on STATIC_MEMORY
+       depends on STATIC_MEMORY && DOM0LESS_BOOT
        help
          This option enables statically shared memory on a dom0less system.
 
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 4d6fe051641d..e0e5f4485d1f 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -100,7 +100,7 @@ config NUMA
 
 config STATIC_MEMORY
        bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED
-       depends on ARM
+       depends on ARM && DOM0LESS_BOOT
        help
          Static Allocation refers to system or sub-system(domains) for
          which memory areas are pre-defined by configuration using physical



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.