[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 10 Nov 2023 10:38:42 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8BJ5wQ/LJVeDBn/yuU7ie93TWr7fYaI4peJi9H3d1rU=; b=naI9hoFWpYsUEU43tPfM+2AV7EngRHm/vyRW9VVS4/lQwrcEcyvUhliDx84VuKAbNKX1+VNGf/clYIyXYyGaxD3RbGnE+T/7GIGCOW6YFXtYQnJNO3rFudP/uBwGqPJH7DvQY+KNNGVSwAGoTSS1lzhayQ4ue1sUldYCQJTUghJKc1jtQcAHoBIBdKFNiKayzRHi9DmGoDNUes8tXNC9jriyMC/GkAirs7PQTdEoXaVjhkgC6nQxjqvYONnRewiNguVl7/5amR4UdFMRl4+pKjviYRhG6uA226AnOafUH5O2zm3K/4H5+NnqgOQQyiuik86GY/WluQtqBoN3k6V4IA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X7F1+F20Kay8c9zO6eMn0sYnvuZnKVGNxb935upH95+U2Kvq6knc7XnbVXujk1chO/qvKlpwU9mkHfNXYWuoXESbp0yji3GZu2sVdsPRxapQKz0KnPUiwSer/YxCTUGxkE6ihbD1p+3Vhmwii9HROw4VAyb3yDhWObONtF8tf7aTDO2QnhThRF11ZpBwKE6654QisgOeVKhln0PbFB7RgoVix5CwTGQCMaKabTA1LA27WFf/Jb0gE2a84D4/19zHLMqEt1N7w4HMPmXWwResqkLV1mFMUc5J7GUubI1A0rodNQaMkuLmS+JQN8bGkIpXMJRw2rNgXNaPJ8HXyPaw5g==
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 10 Nov 2023 09:38:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 10/11/2023 10:30, Luca Fancellu wrote:
> 
> 
>> On 10 Nov 2023, at 09:05, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>>
>> Hi Michal,
>>
>>>>
>>>> +config DOM0LESS_BOOT
>>>> +       bool "Dom0less boot support" if EXPERT
>>>> +       depends on ARM
>>> You're in the Arm Kconfig, so there should be no need for this dependency 
>>> (it is implicit).
>>>
>>> Apart from that, we have 2 features: static mem and static shmem that are 
>>> only meant for dom0less domUs.
>>> Shouldn't we make them dependent on DOM0LESS_BOOT? Otherwise, what is the 
>>> purpose of selecting them
>>> with DOM0LESS_BOOT=n?
>>
>> Sure, I’ll add the dependencies and remove the ARM one
> 
> Just to be sure, is it what you are asking?
See below

> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 0399f2faf734..d9c5340ff3a2 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -90,7 +90,6 @@ config GICV2
> 
>  config DOM0LESS_BOOT
>         bool "Dom0less boot support" if EXPERT
> -       depends on ARM
>         default y
>         help
>           Dom0less boot support enables Xen to create and start domU guests 
> during
> @@ -214,7 +213,7 @@ source "arch/arm/tee/Kconfig"
> 
>  config STATIC_SHM
>         bool "Statically shared memory on a dom0less system" if UNSUPPORTED
> -       depends on STATIC_MEMORY
> +       depends on STATIC_MEMORY && DOM0LESS_BOOT
no need for && DOM0LESS_BOOT

>         help
>           This option enables statically shared memory on a dom0less system.
> 
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 4d6fe051641d..e0e5f4485d1f 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -100,7 +100,7 @@ config NUMA
> 
>  config STATIC_MEMORY
>         bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED
> -       depends on ARM
> +       depends on ARM && DOM0LESS_BOOT
no need for ARM. DOM0LESS_BOOT already depends on ARM.

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.