[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 10 Nov 2023 09:40:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=49iWbs0oTofh0qgWuQtE0ROcS+N2iYb2ciHgBI9nlY4=; b=GeGkT+DurCGi03bKi8oYFKUp5w3cCcGTI7QEthYz9o2RtsLUGYuiZTNSBIVUBJ2DD9J18TO7xUi36jt74pBjECcu3+oqQLI7ud3ZsTPflPWnZb/m7tXQrXyvyG751wIjrYirolMA4cHwbKRCZmfUQpdrb1KFOKHaRVB1nBk/238whl4S4ZBL/CknZAIg+7ANSdM9WkvKIEDoFaH5FDilT4QIpVja5Nbct7ZzfX6LMIeQr5U8EhzErwVP1332kl1UO89hT6b/aQuX8xPhnBZn/6L/HGchtPDRgW3QrF+5t+G092hwaYQtoucboCImq5yXBOqR8XWsI/zQgIG67H7AlQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=49iWbs0oTofh0qgWuQtE0ROcS+N2iYb2ciHgBI9nlY4=; b=mOLbumZCJrwWHCEAkFtY4Jkkm9KuaPWwhlfOYMiB82gZVFh47tFg76Q4ULFQP18O8h6TC8Bedoj1daUYkDYmycX35XluHPYRXddPZdGYvDXNvR+dX/PtV1T/7AS4xxTjziSPNLz68OH4bYZvLWtKHYQXcGHQyYzhPMEFPYrNIaPs7X+0Y/Ttt8XxRbDbh7JZu08rDU5YpJYtxogldSjR+LDKZ9NBwlkz47BTK9KFxMaqqFg7m4MYbofl3mkZdw6WhbFol9/QgY5KzN2Ienp5I7pSb3qK6WKFhmDvmrJR/lDaefVn/NSS2Q+YcwJBdRs/TX3iTGIIS8rorqApUq6A8A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aq2l+IF6edK7ofn3k24soZav3WcqE1/vS+R3Xq04CygGacEM9G3+fMaO69705QheFiQQuabwtHZ5+w2cwmIPUQYa8SQMO/WkQCv6OXSQ7Rg2kP+mbOo9NVAMc7JupTl4a3r6CVJBpLuzN3je1kInGPDNZq0X4jUnAWRTBCZVok+ySYhFyEBcQL6e3jV8wHAyyKSFxRg4014MzXdcLwIHARS7vDSkAYqICNY+3zKc+spgcW2QT/VxTICbp+J/pCf8v0go21JFPGAbzJEh1LRuqk6irvFaTnFUD3/leHnO7+sEbtaY5KpfwKyNSyYSB54dqOnDPQBKHK1YkQO1ZUJK0w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nV/a2u5nXa8jDLStHLR81kpqOJUPVhkzp3ge+4g+CUUjHaW+BPaYpXRJBoAIpB7U0kOzXP/dDBo2/V3aFBKE8a6UwivQC3zlTXNigGrIa0RgDiAhV/umHlFWaUdSwcCREp5PjUflb1ofc/Jq2zipspj+Gda8nKkb/4uCj3K2V16uphuH33HOZmDC1YPpYi4zq44Ol8bsxDzpylBa5NeDjYbN5jtufW4KFKgxXsBl+1zQ42WAqj+xcy7q+K2H1NhKVaqlJDO1Qr0MnuCmTu2JDYntWLHr0gNI+PMH2XnI79TdqB2AbkXiEVnvNhFhIQXEE8a43heO9HZhbvBV43cueg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 10 Nov 2023 09:40:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaEuwVAcRvSKcty0WG4JBMWUF0b7BzQ0WAgAABDgCAAAbKAIAAAmwAgAAAZoA=
- Thread-topic: [PATCH v3 5/5] arm/dom0less: introduce Kconfig for dom0less feature
> On 10 Nov 2023, at 09:38, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Hi,
>
> On 10/11/2023 10:30, Luca Fancellu wrote:
>>
>>
>>> On 10 Nov 2023, at 09:05, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
>>>
>>> Hi Michal,
>>>
>>>>>
>>>>> +config DOM0LESS_BOOT
>>>>> + bool "Dom0less boot support" if EXPERT
>>>>> + depends on ARM
>>>> You're in the Arm Kconfig, so there should be no need for this dependency
>>>> (it is implicit).
>>>>
>>>> Apart from that, we have 2 features: static mem and static shmem that are
>>>> only meant for dom0less domUs.
>>>> Shouldn't we make them dependent on DOM0LESS_BOOT? Otherwise, what is the
>>>> purpose of selecting them
>>>> with DOM0LESS_BOOT=n?
>>>
>>> Sure, I’ll add the dependencies and remove the ARM one
>>
>> Just to be sure, is it what you are asking?
> See below
>
>>
>> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
>> index 0399f2faf734..d9c5340ff3a2 100644
>> --- a/xen/arch/arm/Kconfig
>> +++ b/xen/arch/arm/Kconfig
>> @@ -90,7 +90,6 @@ config GICV2
>>
>> config DOM0LESS_BOOT
>> bool "Dom0less boot support" if EXPERT
>> - depends on ARM
>> default y
>> help
>> Dom0less boot support enables Xen to create and start domU guests
>> during
>> @@ -214,7 +213,7 @@ source "arch/arm/tee/Kconfig"
>>
>> config STATIC_SHM
>> bool "Statically shared memory on a dom0less system" if UNSUPPORTED
>> - depends on STATIC_MEMORY
>> + depends on STATIC_MEMORY && DOM0LESS_BOOT
> no need for && DOM0LESS_BOOT
Thanks, yes I was unsure about that indeed
>
>> help
>> This option enables statically shared memory on a dom0less system.
>>
>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
>> index 4d6fe051641d..e0e5f4485d1f 100644
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -100,7 +100,7 @@ config NUMA
>>
>> config STATIC_MEMORY
>> bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED
>> - depends on ARM
>> + depends on ARM && DOM0LESS_BOOT
> no need for ARM. DOM0LESS_BOOT already depends on ARM.
Ok, I’ll update it
>
> ~Michal
>
|
