[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/5] arm/dom0less: put dom0less feature code in a separate module
- To: Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 20 Nov 2023 14:27:36 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJmh38ehQC9Pcj/51VUC4Ah9+U/3SWX1NyuDybmZXZc=; b=EtyM5de2ysTa5df8+P7ZzmJahWKS7i2rn2fQ7KjRdtf8TVmRMFIxWLIpMk0527OYMJbHGzk8gxj5JmmeAU9dwDuoZZCopuAy86gwhi3WepHnl4UNiSfWYBpdG1rTKbQ0zkLjl8fcNWKhI30kjDokrTwWFGuUzgHdaHwjNFbij+cJSJmp+rlV48yoGCmyFq/g2vUirqg4ByT8Wo0TN4rR1ljLAbUNIPgrpTiLqDKX8cmmiUv7YN8kOM3xEY8RMYKZkNTdntL5tR6OszVMCmuoVTJaOYp76woRXLLlJnrZ1Hm0iZUbclx9X88C6S7fSHphRmvIk37ikTk0TdXbTtqEnw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dJmh38ehQC9Pcj/51VUC4Ah9+U/3SWX1NyuDybmZXZc=; b=l5zNp/hrq2JLAspqnzotcueIP32IhU0HAjod+oVrs/rBWoSjc0xqUGfUlRZUCm2jNBwoaSz17dMjlB/z8WRUhZrzLBQTIQ0pA28DEX4My092BSlf/jnwFm55f/Wqm/MDpfntEVDi0lt6TD0G+PGF35QR7I7XpxTvGJA4/U42UoqFrrGnujVe7v76uX7rSskhkZ9+1txOPVs9xGFGREtD62ROoU0iwZvxvnPohBJaGTuuXdxUI3KUJAOQDKD6wjdoT5TC6/g90ASfmR0DLvCpGCMuXapuHWg3aD3DK9X9zr75H33cUtedq/IQoEWZJMVW9PsmOzLljErlNrlFBWGC1g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NU8QDb+bsviL8jjdPDRGTd1YhPUZUaT+4a1Bh3lmv0I4p/cEopz0CKH5WkEBmFKlxT5Yy/XG9SQLWDTxmQGGk1ZjSQTUGbL/PSLwoJhxtrPPBYQveTCyCBjzZkndowaSo93LRrCvrouQNLC/TEioTESub201oXQNSA9m9hqcTLHPVc9S7NJuKsqX+iQDicNRAHQ5oLXupo+vcSBEXV0d2UXgxncyCxTVPeJUH6pNkZOCWLmMM+Svdtrt1jwgyIg9r6M+QN1gl07KcqCrLZ0pFLykeBmDNYqGR9iaDjxNlyq3W6jhtEpct0jK3UxWGYDwdd0NQBwxX7az19A4TYZjbg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfyY9ZABOMRk2oCkSl32kXlekqkoqWdiiOTwPokwM4a0+nZXWqVZgKgjixZdPLxO3P6sT8B4Dp2Fh7k21RwskC0c8UDbMt9bJmfz1Xnm6pwF1/8NfZVPnxQHJiTFAHw6YZgUqFDDTHSSpw+81fMN+1c0g8SfUNudKBNJKhqCYjUGpjQYzcZAVfzthadZmKxf+v4kbMsXZmcAxXJMS5Jt3aODu6FeN/1WvIRTBcMk/S7mNDzjy4zy65B/pauj1qE0NbvPB3OUwSF1w6A/F1zO8PL/ATANGQf5MO2XvQPaT02Tz3mEgca5H3DXgvhIWwX5Qz/uAVWj8XCuhE7OmvHsMA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 20 Nov 2023 14:27:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaG4QK5MCX1n0HKkuH99Fs2YTq1LCDN0+AgAAIlICAAARyAA==
- Thread-topic: [PATCH v5 3/5] arm/dom0less: put dom0less feature code in a separate module
>>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
>>>
>>> with one remark...
>>>
>>>> ---
>>>> Changes from v4:
>>>> - fixed name in inclusion macro __ASM_* instead of __ARM_*, fixed
>>>> emacs local variable 'end:', style fix (Michal)
>>>> Changes from v3:
>>>> - remove header in dom0less-build.c (Michal)
>>>> Changes from v2:
>>>> - move allocate_bank_memory back in domain_build.c, remove header
>>>> from dom0less-build.c.
>>>> ---
>>>> xen/arch/arm/Makefile | 1 +
>>>> xen/arch/arm/dom0less-build.c | 1018 +++++++++++++++++
>>>> xen/arch/arm/domain_build.c | 1265 +++------------------
>>>> xen/arch/arm/include/asm/dom0less-build.h | 20 +
>>>> xen/arch/arm/include/asm/domain_build.h | 60 +
>>>> xen/arch/arm/include/asm/setup.h | 1 -
>>>> xen/arch/arm/setup.c | 33 +-
>>>> 7 files changed, 1240 insertions(+), 1158 deletions(-)
>>>> create mode 100644 xen/arch/arm/dom0less-build.c
>>>> create mode 100644 xen/arch/arm/include/asm/dom0less-build.h
>>>>
>>>
>>> [...]
>>>> diff --git a/xen/arch/arm/include/asm/dom0less-build.h
>>>> b/xen/arch/arm/include/asm/dom0less-build.h
>>>> new file mode 100644
>>>> index 000000000000..81446cbd8bf3
>>>> --- /dev/null
>>>> +++ b/xen/arch/arm/include/asm/dom0less-build.h
>>>> @@ -0,0 +1,20 @@
>>>> +/* SPDX-License-Identifier: GPL-2.0-only */
>>>> +
>>>> +#ifndef __ASM_DOM0LESS_BUILD_H_
>>>> +#define __ASM_DOM0LESS_BUILD_H_
>>>> +
>>>> +#include <asm/kernel.h>
>>> No need for this include, especially if you are removing it in the
>>> subsequent patch.
>>
>> Are you suggesting that this patch builds without including asm/kernel.h?
> Yes.
>
>>
>>> This could be done on commit (+ there is a conflcit between your series and
>>> Henry's mmu/mpu split)
>>
>> While I am in general happy to handle some changes on commit, I don't
>> want to solve conflict between series.
>>
>> One will have to rebase on top of the others. I suggest that this is
>> just rebased on top of Henry, purely because I will likely commit it
>> today or tomorrow.
> Sounds ok.
Hi Julien, Michal,
I will rebase the serie on top of Henry’s patches when they will be merged and
I will address the remaining
comments.
Cheers,
Luca
|
