[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v5 3/5] arm/dom0less: put dom0less feature code in a separate module
Hi Luca, On 20/11/2023 14:27, Luca Fancellu wrote: Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx> with one remark...--- Changes from v4: - fixed name in inclusion macro __ASM_* instead of __ARM_*, fixed emacs local variable 'end:', style fix (Michal) Changes from v3: - remove header in dom0less-build.c (Michal) Changes from v2: - move allocate_bank_memory back in domain_build.c, remove header from dom0less-build.c. --- xen/arch/arm/Makefile | 1 + xen/arch/arm/dom0less-build.c | 1018 +++++++++++++++++ xen/arch/arm/domain_build.c | 1265 +++------------------ xen/arch/arm/include/asm/dom0less-build.h | 20 + xen/arch/arm/include/asm/domain_build.h | 60 + xen/arch/arm/include/asm/setup.h | 1 - xen/arch/arm/setup.c | 33 +- 7 files changed, 1240 insertions(+), 1158 deletions(-) create mode 100644 xen/arch/arm/dom0less-build.c create mode 100644 xen/arch/arm/include/asm/dom0less-build.h[...]diff --git a/xen/arch/arm/include/asm/dom0less-build.h b/xen/arch/arm/include/asm/dom0less-build.h new file mode 100644 index 000000000000..81446cbd8bf3 --- /dev/null +++ b/xen/arch/arm/include/asm/dom0less-build.h @@ -0,0 +1,20 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef __ASM_DOM0LESS_BUILD_H_ +#define __ASM_DOM0LESS_BUILD_H_ + +#include <asm/kernel.h>No need for this include, especially if you are removing it in the subsequent patch.Are you suggesting that this patch builds without including asm/kernel.h?Yes.This could be done on commit (+ there is a conflcit between your series and Henry's mmu/mpu split)While I am in general happy to handle some changes on commit, I don't want to solve conflict between series. One will have to rebase on top of the others. I suggest that this is just rebased on top of Henry, purely because I will likely commit it today or tomorrow.Sounds ok.Hi Julien, Michal, I will rebase the serie on top of Henry’s patches when they will be merged and I will address the remaining comments. They are now merged. Cheers, -- Julien Grall
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |