[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] dead qemu make targets in toplevel Makefile

On Tue, 2014-10-07 at 15:26 +0200, Olaf Hering wrote:
> On Tue, Oct 07, Ian Campbell wrote:
> > It looks like my build scripts use "make -C tools $FOO-force-update", so
> > removing them would be a problem for me personally.
> The dead code is in the toplevel Makefile, the command above uses
> tools/Makefile.

Sorry, I tried to say "would *not* be a problem", because as you note
I'm using the tools/Makefile version.

> > On the other hand since they are only for use by end users and not
> > dependencies of any other rule I suppose we could just nuke the
> > conditionals but leave the rules themselves?
> Yes, but shouldnt this be easier like "make update-qemu-trad" which
> downloads and forces the tree(s) to be in a given state? And while we
> are at it, I find something like "make clean-qemu-trad" useful. It
> should check if the subdir is a git tree, and do either a "git clean
> -dfx" or "make clean".
> And perhaps all that should be in two easy targets like 'update-subprj'
> and 'clean-subprj'. There is likely a better string than "subprj".

If you want to go further than simply fixing up the existing things then
have at it, I've no in principal objections...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.