Re: [Xen-devel] [PATCH 01/12] xen: clang: Support correctly cross-compile

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 28/03/2019 09:55, Jan Beulich wrote:
> > > > On 27.03.19 at 19:45, <julien.grall@xxxxxxx> wrote:
> > Clang uses "-target" option for cross-compilation.
> > --- a/config/StdGNU.mk
> > +++ b/config/StdGNU.mk
> > @@ -1,8 +1,13 @@
> >   AS         = $(CROSS_COMPILE)as
> >   LD         = $(CROSS_COMPILE)ld
> >   ifeq ($(clang),y)
> > -CC         = $(CROSS_COMPILE)clang
> > -CXX        = $(CROSS_COMPILE)clang++
> > +ifneq ($(CROSS_COMPILE),)
> > +CC         = clang -target $(CROSS_COMPILE:-=)
> > +CXX        = clang++ -target $(CROSS_COMPILE:-=)
> Is dropping dashes from the variable uniformly correct? If so,
> could you please clarify in the commit message why that is?
The target option requires the following format:

<arch><sub>-<vendor>-<sys>-<abi>

In other places, we need the trailing dash as GNU tools are using the same 
format as above with a dash to separate the tool name.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel