[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 09/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending

 >>> On 29.04.16 at 04:41, <quan.xu@xxxxxxxxx> wrote:
> Now I check the status in caller to make the print include caller which is 
> failed, instead print in iommu_flush_all().
> i.e., 
> vtd_crash_shutdown()
> {
> ..
>     if ( iommu_flush_all() )
>                " vtd_crash_shutdown: IOMMU flush all failed.\n");
> ..
> }
> I am afraid I still don't get the point. To be honest, in such a fix,
> The print is not so useful to me ( Correct me, I will continue to enhance 
> it).

So do you think it would be more useful to leave the admin with no
clue why a system misbehaves, instead of providing clear indication?
IOW - what usefulness concerns do you have?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.