Re: [Xen-devel] [PATCH v3 03/14] x86/cpu/vpmu: Add Hygon Dhyana and AMD Zen support for vPMU

[Pu Wen <puwen@xxxxxxxx>]

On 2019/3/27 16:38, Jan Beulich wrote:
> On 27.03.19 at 09:16, <puwen@xxxxxxxx> wrote:
> > On 2019/3/27 0:10, Jan Beulich wrote:
> > > On 25.03.19 at 14:30, <puwen@xxxxxxxx> wrote:
> > > > +    default:
> > > > +        printk(XENLOG_WARNING "VPMU: Unsupported CPU family %#x\n",
> > > > +               current_cpu_data.x86);
> > > > +        return -EINVAL;
> > > >        }
> > > While I'm not going to insist in cases where you add to existing
> > > switch()-es which lack such blank lines, please add a blank line
> > > between the case blocks here. Yet then again I wonder whether
> > > the default case wouldn't better move into the shared function
> > > as well, keying off of e.g. num_counters still being zero.
> > Then as there is only one case in hygon_vpmu_init(), how about remove
> > switch()-es in this function?
> Well, personally I'd prefer to keep the switch(), as that what's
> going to be needed once you introduce a second model, but I
> won't insist.
Keeping the switch() is also fine to me.

--
Regards,
Pu Wen



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel