[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in libxl [and 1 more messages]
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Date: Fri, 15 Oct 2021 13:13:02 +0100
- Cc: Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Rahul Singh <rahul.singh@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>
- Delivery-date: Fri, 15 Oct 2021 12:13:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree
node in libxl [and 1 more messages]"):
> On 15.10.2021 13:46, Ian Jackson wrote:
> > Maybe something like
> >
> > // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
> > // decide whether to enable vpci, rather than using c_info->passthrough.
> > // This will be insufficient if and when ARM does PCI hotplug.
>
> Well we are not enabling vpci. We are creating a DT node for it.
> So either I will write:
> /*
> * Note: libxl_arm directly examines num_pcidevs to decide whether
> * to create a vPCI DT node, rather than using c_info->passthrough.
> * This will be insufficient if and when ARM does PCI hotplug.
> */
That sounds good to me. Thank you for correcting me :-).
Ian.
|
